Ticket #3886 (closed enhancement: wontfix)

Opened 4 months ago

Last modified 3 months ago

Some tags on last.fm contain bad characters

Reported by: dgrant Assigned to: luks
Priority: minor Milestone:
Component: Picard Tagger Version: Picard 0.10.0
Keywords: plugin, Last.fm Cc:
Browser: OS:

Description

I have used the last.fm plugin to add genres to my entire album. Thanks a lot for this excellent plugin. Now I am writing some python scripts using the eyeD3 library that will remove some of the useless genres that only apply to one artist. Then I can actually use these genres to play music of a certain genre.

The problem is that some tags from last.fm contain characters that cause eyeD3 to barf. Examples are semi-colons and the "<" symbol. Here's a patch that filters out characters that eyeD3 (and perhaps other taggers) doesn't like.

Attachments

rejectTags.patch (0.6 kB) - added by dgrant on 2008-08-02 05:07:37.
rejectTags.patch - rejects tags with "bad" characters. At least "bad" according to eyeD3

Change History

2008-08-02 05:07:37 changed by dgrant

  • attachment rejectTags.patch added.

rejectTags.patch - rejects tags with "bad" characters. At least "bad" according to eyeD3

2008-08-02 05:08:42 changed by dgrant

  • owner set to luks.

2008-08-02 05:08:54 changed by dgrant

  • priority changed from normal to minor.

2008-08-02 05:38:30 changed by luks

I don't see why for example - or & are bad. I think they are not so rare in valid genre names. You should use Mutagen for the scripts, not eyeD3 :)

2008-08-02 05:38:40 changed by luks

  • component changed from MusicBrainz Server to Picard Tagger.

2008-08-02 05:41:25 changed by dgrant

Thanks, I'll give mutagen a try.

2008-09-07 13:02:47 changed by luks

  • status changed from new to closed.
  • resolution set to wontfix.

Closing this, I don't think it's a good idea.

Add/Change #3886 (Some tags on last.fm contain bad characters)




Action