Ticket #1291 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

Short FLACs can't be analyzed

Reported by: anonymous Assigned to:
Priority: normal Milestone: Picard 0.7.0
Component: libtunepimp Version: Picard 0.7.0 BETA 2
Keywords: Cc:
Browser: OS:

Description

FLACs up to 2 minutes (and a few seconds) show the error "Cannot decode audio file." Longer FLACs work. Decoding the file to PCM WAV and trying again works.

Attachments

Change History

2006-04-06 11:56:05 changed by luks

  • owner set to rob.
  • component changed from Picard Tagger to libtunepimp.

2006-04-06 11:56:14 changed by luks

  • owner deleted.

2006-04-07 16:04:00 changed by GURT

  • os deleted.

I have a 2 minute 14 second .ogg that does the same thing.

2006-04-10 21:10:44 changed by anonymous

I saw this, too. This fixed it for me:

diff -ur libtunepimp-0.5.0-alpha1.orig/plugins/flac/flacdecode.cpp libtunepimp-0.5.0-alpha1/plugins/flac/flacdecode.cpp --- libtunepimp-0.5.0-alpha1.orig/plugins/flac/flacdecode.cpp 2006-02-15 21:31:47.000000000 -0500 +++ libtunepimp-0.5.0-alpha1/plugins/flac/flacdecode.cpp 2006-04-10 16:47:37.000000000 -0400 @@ -221,6 +221,8 @@

break;

state = FLACstream_decoder_get_state(decoder);

+ if (state == FLACSTREAM_DECODER_END_OF_STREAM) + break;

if (state != FLACSTREAM_DECODER_SEARCH_FOR_FRAME_SYNC

state != FLACSTREAM_DECODER_READ_FRAME)

2006-04-10 21:18:49 changed by ojnkpjg

erg, that was ugly and i forgot to login: 

diff -ur libtunepimp-0.5.0-alpha1.orig/plugins/flac/flacdecode.cpp libtunepimp-0.5.0-alpha1/plugins/flac/flacdecode.cpp
--- libtunepimp-0.5.0-alpha1.orig/plugins/flac/flacdecode.cpp   2006-02-15 21:31:47.000000000 -0500
+++ libtunepimp-0.5.0-alpha1/plugins/flac/flacdecode.cpp    2006-04-10 16:47:37.000000000 -0400
@@ -221,6 +221,8 @@
           break;

        state = FLAC__stream_decoder_get_state(decoder);
+      if (state == FLAC__STREAM_DECODER_END_OF_STREAM)
+           break;
        if (state != FLAC__STREAM_DECODER_SEARCH_FOR_FRAME_SYNC ||
            state != FLAC__STREAM_DECODER_READ_FRAME)
        {

not sure if this fixing the real problem, but it seems to produce correct results for me

2006-04-16 11:25:41 changed by luks

  • status changed from new to closed.
  • resolution set to fixed.

(In [7230]) Added checks for end of stream in FLAC and Vorbis plugins. Thanks ojnkpjg! (closes #1291)

2006-04-16 11:26:05 changed by luks

  • milestone set to Picard 0.7.0.

Add/Change #1291 (Short FLACs can't be analyzed)




Action